Conversation
overriding Hyrax file_set media_display partials (image, PDF, office) and the base representative media partial, using thumbnail_alt_text_for.
haitzlm
approved these changes
Apr 10, 2026
Contributor
haitzlm
left a comment
There was a problem hiding this comment.
Excellent work on remediation. All tests passed, who am I do doubt what they did?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch improves accessibility (including common WAVE findings) across Hyrax views and the app shell, adds meaningful alt text for representative thumbnails on work and file-set pages, and tightens the notifications badge behavior for screen readers. View and helper specs are added or updated to lock in the new markup.
Motivation
alttext instead of generic or missing descriptions.Changes
Thumbnails and representative media
hyrax/file_sets/media_displaypartials for image, PDF, and office documents to passalt: thumbnail_alt_text_for(...).hyrax/base/_representative_media.html.erbso the default representative image uses the same alt helper.Shell and Hyrax UI accessibility
<label>(visually hidden where appropriate) for catalog and “my” dashboard search forms.sr-onlylabel with the batch checkbox and addaria-labelfor “include work in collection” / batch selection semantics.<h2>when parent works exist (_parent_relationship_table).<h2>.role,aria-*,menuitem) and wire the toggle to the menu it controls.Notifications
notification_count_badgefromrender_notificationsinHyraxHelper.aria-hidden="true"and invisible styling; when positive, show the numeric count with the danger label and noaria-hidden.Locales
config/locales/hyrax.en.ymlfor new user-visible copy tied to the above views.Tests
notification_count_badgeinhyrax_helper_spec.Wave view of item detail page. Includes 1 warning for a duplicate link that cannot be fixed without more in-depth JavaScript rework.
