Skip to content

Conversation

@jijiseong
Copy link
Contributor

@jijiseong jijiseong commented May 23, 2024

Description

close #3213

zIndex of FloatingToolbar is 50

I change zIndicies of SiteHeader and FixedToolbar to 60

2024-05-23.6.46.58.mov

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2024

⚠️ No Changeset found

Latest commit: e93b5dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 8:21am

@jijiseong jijiseong changed the title Fix/z index Fix: zIndicies of SiteHeader and FixedToolbar #3213 May 23, 2024
@jijiseong jijiseong changed the title Fix: zIndicies of SiteHeader and FixedToolbar #3213 Fix: zIndicies of the SiteHeader and FixedToolbar #3213 May 23, 2024
@felixfeng33 felixfeng33 enabled auto-merge May 23, 2024 13:32
felixfeng33
felixfeng33 previously approved these changes May 23, 2024
@zbeyens
Copy link
Member

zbeyens commented May 24, 2024

Thanks for the PR! Please update changelog.mdx

@zbeyens zbeyens disabled auto-merge May 24, 2024 00:42
zbeyens
zbeyens previously approved these changes May 24, 2024
@jijiseong
Copy link
Contributor Author

jijiseong commented May 24, 2024

Thanks for the PR! Please update changelog.mdx

My changes have no impact on the packages.
Should I add the changeset?

@felixfeng33
Copy link
Collaborator

Thanks for the PR! Please update changelog.mdx

My changes have no impact on the packages. Should I add the changeset?

needn't need add that. Need update this file https://github.com/udecode/plate/blob/main/apps/www/content/docs/components/changelog.mdx.

@jijiseong jijiseong dismissed stale reviews from zbeyens and felixfeng33 via 82456db May 24, 2024 08:02
@jijiseong
Copy link
Contributor Author

needn't need add that. Need update this file https://github.com/udecode/plate/blob/main/apps/www/content/docs/components/changelog.mdx.

I updated that!

@jijiseong
Copy link
Contributor Author

jijiseong commented May 24, 2024

there is a prettier bug.. sorry
I will fix it

@jijiseong jijiseong requested review from felixfeng33 and zbeyens May 24, 2024 08:11
@zbeyens zbeyens merged commit 9bfe490 into udecode:main May 24, 2024
@jijiseong jijiseong deleted the fix/z-index branch May 24, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zIndex bug in SiteHeader, FixedToolbar

3 participants