fix: use instance-specific pluginKey as transaction meta key in BubbleMenu/FloatingMenu to prevent cross-contamination#7512
Open
Re-cool wants to merge 1 commit intoueberdosis:developfrom
Conversation
…eMenu/FloatingMenu to prevent cross-contamination
🦋 Changeset detectedLatest commit: 48e29ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 72 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
This builds on the work in #7445 by scoping the transaction meta key to each instance's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Overview
When multiple
BubbleMenu/FloatingMenuinstances use differentpluginKeyvalues, all instances respond to any instance's option updates because the transaction meta key is hardcoded as"bubbleMenu"/"floatingMenu"instead of using the providedpluginKey.Implementation Approach
BubbleMenuView/FloatingMenuView: AcceptpluginKeyin constructor and use it ingetMeta()instead of hardcoded stringBubbleMenu/FloatingMenu: UsepluginKeyprop insetMeta()instead of hardcoded stringFloatingMenuextension: Usethis.options.pluginKeyinupdateFloatingMenuPositioncommandDefault values remain
"bubbleMenu"/"floatingMenu", maintaining full backward compatibility.Testing Done
extension-bubble-menuandextension-floating-menupackagespluginKeyisolation with both string andPluginKeyinstance types, cross-contamination prevention between instances, command meta key scoping, and backward compatibility with defaultpluginKeyVerification Steps
BubbleMenuorFloatingMenuinstances with differentpluginKeyvalues and differentoptions(e.g., differentplacement)Checklist