add tests for multicaster#169
Open
otariidae wants to merge 6 commits into
Open
Conversation
Author
|
理想的な挙動に寄せたので現状はテスト落ちている
|
|
senderを繋ぐ前にconnect_receiverの要求がきた場合 |
ruu413
approved these changes
Nov 2, 2022
otariidae
force-pushed
the
test-multicaster
branch
from
4f3afa8 to
de53fe4
Compare
Azuki-bar
approved these changes
Nov 6, 2022
Member
Azuki-bar
left a comment
Azuki-bar
left a comment
There was a problem hiding this comment.
何やっているか分からないけどテスト実装していそうだしヨシ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #142
とりあえず議論の叩き台としてconnect_senderとconnect_receiver単体のテストを作成