Skip to content

feat: options to display continuous sliders#81

Merged
uga-rosa merged 3 commits intouga-rosa:mainfrom
Alan-Kuan:main
Jun 3, 2023
Merged

feat: options to display continuous sliders#81
uga-rosa merged 3 commits intouga-rosa:mainfrom
Alan-Kuan:main

Conversation

@Alan-Kuan
Copy link
Contributor

Hello.

I like what this plugin does, but what annoyed me was that the appearance of the sliders looked uncontinuous because the background color of the points were empty.
Thus, I added some options to make it possible to display continuous sliders.
In order not to introduce breaking changes to everyone's configs, the default behavior is same as before.

The options I added:

  • empty_point_bg
    • default: true
    • whether to give points background colors
  • point_color_on_dark
    • default: "#ffffff"
    • point color on a dark background
    • only works if empty_point_bg is false
  • point_color_on_light
    • default: "#000000"
    • point color on a light background
    • only works if empty_point_bg is false

The followings are some screenshots.

20230603_22h52m44s_grim

20230603_22h53m14s_grim

Besides, I updated the document, so you can also take a look.

Please tell me if there's anything I missed.

@uga-rosa
Copy link
Owner

uga-rosa commented Jun 3, 2023

As for what you want to do, I understand and I think the policy is good.

@Alan-Kuan
Copy link
Contributor Author

@uga-rosa I finished. Please take a look.

@uga-rosa
Copy link
Owner

uga-rosa commented Jun 3, 2023

LGTM
Thanks for your work and contribution!

@uga-rosa uga-rosa merged commit 72461f8 into uga-rosa:main Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants