Merged
Conversation
jaywcjlove
reviewed
Apr 14, 2023
core/src/Tab.tsx
Outdated
| export interface TabProps extends React.DetailedHTMLProps<React.HTMLAttributes<HTMLDivElement>, HTMLDivElement> { | ||
| id: string; | ||
| index?: number; | ||
| AxisYType?: boolean; //Y轴是否可上下拖动 |
Member
There was a problem hiding this comment.
props “参数” 命名应该使用小驼峰，开头字母小写，
组件名称和类型名称使用大驼峰
这个 props 可以命名为 dragableY 更为准确表达意思
added 2 commits
April 14, 2023 11:12
jaywcjlove
reviewed
Apr 14, 2023
| id: string; | ||
| index?: number; | ||
| yAxisType?: boolean; //Y轴是否可上下拖动 | ||
| dragableY?: boolean; //Y轴是否可上下拖动 |
Member
There was a problem hiding this comment.
@Amber-Nan 下面注释方法有代码提示
/** Y轴是否可上下拖动 */
dragableY?: boolean;
jaywcjlove
added a commit
that referenced
this pull request
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.