Parameterize ONNX --opset-version#3154
Merged
glenn-jocher merged 1 commit intoultralytics:masterfrom May 16, 2021
CristiFati:master
Merged
Parameterize ONNX --opset-version#3154glenn-jocher merged 1 commit intoultralytics:masterfrom CristiFati:master
--opset-version#3154glenn-jocher merged 1 commit intoultralytics:masterfrom
CristiFati:master
Conversation
Member
|
@CristiFati sure, that makes sense. Thank you for your contributions! |
Member
|
/rebase |
--opset-version--opset-versio
--opset-versio--opset-version
Lechtr
pushed a commit
to Lechtr/yolov5
that referenced
this pull request
Jul 20, 2021
(cherry picked from commit 9ab561d)
Merged
BjarneKuehl
pushed a commit
to fhkiel-mlaip/yolov5
that referenced
this pull request
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into a situation where due to (external) constraints opset version 12 is unsupported (too new). Made it configurable in case anyone else needs it. The change is trivial, but I'm not sure whether it brings any value. It's always a matter of gains / losses: the gain is the ability of configuring the version, the loss is another argument (increased complexity). Perfectly fine if it's going to be rejected.
Might add some other enhancements (fixes) if I encounter problems along the way. One that caught my eye, but I didn't look into it yet is:
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhanced customization for ONNX export with opset version selection.
📊 Key Changes
--opset-versionto specify the ONNX opset version.🎯 Purpose & Impact