`cv2.imread(img, -1)` for IMREAD_UNCHANGED by tudoulei · Pull Request #3379 · ultralytics/yolov5

tudoulei · 2021-05-29T00:59:18Z

if you train a 4 channel model, Using the detet.py code will report an error

🛠️ PR Summary

_{Made with ❤️ by Ultralytics Actions}

🌟 Summary

Improved image loading in YOLOv5 to support various image formats.

📊 Key Changes

Modified the image reading function cv2.imread by adding the -1 flag.

🎯 Purpose & Impact

Purpose: To enable the loading of images with their original depth and channel settings (e.g., alpha channel in PNGs).
Impact: Users can now train models with images that have multiple channels or non-standard encodings without pre-processing them. This could lead to more versatility in training datasets and potentially richer model inputs. 🌈🖼️

github-actions

👋 Hello @tudoulei, thank you for submitting a 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

✅ Verify your PR is up-to-date with origin/master. If your PR is behind origin/master an automatic GitHub actions rebase may be attempted by including the /rebase command in a comment body, or by running the following code, replacing 'feature' with the name of your local branch:

git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature  # <----- replace 'feature' with local branch name
git rebase upstream/develop
git push -u origin -f

✅ Verify all Continuous Integration (CI) checks are passing.
✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee

glenn-jocher · 2021-05-29T10:40:28Z

@tudoulei thanks for the PR! It appears you change updates the second argument of cv2.imread() which specifies the ImreadModes, -1 being 'unchanged'.
https://vovkos.github.io/doxyrest-showcase/opencv/sphinx_rtd_theme/enum_cv_ImreadModes.html

Can you provide an example image that is causing an issue with the default code please? Thanks!

glenn-jocher · 2021-05-29T19:08:06Z

Profiling results are acceptable.

%timeit cv2.imread(path, -1)
5.26 ms ± 54.1 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

%timeit cv2.imread(path)
5.27 ms ± 63.5 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

glenn-jocher · 2021-05-29T19:10:38Z

@tudoulei thank you for your contributions to YOLOv5 🚀!

This reverts commit 21a9607.

@kalenmike

* update ci-testing.yml (#3322) * update ci-testing.yml * update greetings.yml * bring back os matrix * update ci-testing.yml (#3322) * update ci-testing.yml * update greetings.yml * bring back os matrix * Enable direct `--weights URL` definition (#3373) * Enable direct `--weights URL` definition @kalenmike this PR will enable direct --weights URL definition. Example use case: ``` python train.py --weights https://storage.googleapis.com/bucket/dir/model.pt ``` * cleanup * bug fixes * weights = attempt_download(weights) * Update experimental.py * Update hubconf.py * return bug fix * comment mirror * min_bytes * Update tutorial.ipynb (#3368) add Open in Kaggle badge * `cv2.imread(img, -1)` for IMREAD_UNCHANGED (#3379) * Update datasets.py * comment Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> * COCO evolution fix (#3388) * COCO evolution fix * cleanup * update print * print fix * Create `is_pip()` function (#3391) Returns `True` if file is part of pip package. Useful for contextual behavior modification. ```python def is_pip(): # Is file in a pip package? return 'site-packages' in Path(__file__).absolute().parts ``` * Revert "`cv2.imread(img, -1)` for IMREAD_UNCHANGED (#3379)" (#3395) This reverts commit 21a9607. * Update FLOPs description (#3422) * Update README.md * Changing FLOPS to FLOPs. Co-authored-by: BuildTools <unconfigured@null.spigotmc.org> * Parse URL authentication (#3424) * Parse URL authentication * urllib.parse.unquote() * improved error handling * improved error handling * remove %3F * update check_file() * Add FLOPs title to table (#3453) * Suppress jit trace warning + graph once (#3454) * Suppress jit trace warning + graph once Suppress harmless jit trace warning on TensorBoard add_graph call. Also fix multiple add_graph() calls bug, now only on batch 0. * Update train.py * Update MixUp augmentation `alpha=beta=32.0` (#3455) Per VOC empirical results #3380 (comment) by @developer0hye * Add `timeout()` class (#3460) * Add `timeout()` class * rearrange order * Faster HSV augmentation (#3462) remove datatype conversion process that can be skipped * Add `check_git_status()` 5 second timeout (#3464) * Add check_git_status() 5 second timeout This should prevent the SSH Git bug that we were discussing @kalenmike * cleanup * replace timeout with check_output built-in timeout * Improved `check_requirements()` offline-handling (#3466) Improve robustness of `check_requirements()` function to offline environments (do not attempt pip installs when offline). * Add `output_names` argument for ONNX export with dynamic axes (#3456) * Add output names & dynamic axes for onnx export Add output_names and dynamic_axes names for all outputs in torch.onnx.export. The first four outputs of the model will have names output0, output1, output2, output3 * use first output only + cleanup Co-authored-by: Samridha Shrestha <samridha.shrestha@g42.ai> Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> * Revert FP16 `test.py` and `detect.py` inference to FP32 default (#3423) * fixed inference bug ,while use half precision * replace --use-half with --half * replace space and PEP8 in detect.py * PEP8 detect.py * update --half help comment * Update test.py * revert space Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> * Add additional links/resources to stale.yml message (#3467) * Update stale.yml * cleanup * Update stale.yml * reformat * Update stale.yml HUB URL (#3468) * Stale `github.actor` bug fix (#3483) * Explicit `model.eval()` call `if opt.train=False` (#3475) * call model.eval() when opt.train is False call model.eval() when opt.train is False * single-line if statement * cleanup Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> * check_requirements() exclude `opencv-python` (#3495) Fix for 3rd party or contrib versions of installed OpenCV as in #3494. * Earlier `assert` for cpu and half option (#3508) * early assert for cpu and half option early assert for cpu and half option * Modified comment Modified comment * Update tutorial.ipynb (#3510) * Reduce test.py results spacing (#3511) * Update README.md (#3512) * Update README.md Minor modifications * 850 width * Update greetings.yml revert greeting change as PRs will now merge to master. Co-authored-by: Piotr Skalski <SkalskiP@users.noreply.github.com> Co-authored-by: SkalskiP <piotr.skalski92@gmail.com> Co-authored-by: Peretz Cohen <pizzaz93@users.noreply.github.com> Co-authored-by: tudoulei <34886368+tudoulei@users.noreply.github.com> Co-authored-by: chocosaj <chocosaj@users.noreply.github.com> Co-authored-by: BuildTools <unconfigured@null.spigotmc.org> Co-authored-by: Yonghye Kwon <developer.0hye@gmail.com> Co-authored-by: Sam_S <SamSamhuns@users.noreply.github.com> Co-authored-by: Samridha Shrestha <samridha.shrestha@g42.ai> Co-authored-by: edificewang <609552430@qq.com>

@kalenmike

* update ci-testing.yml (ultralytics#3322) * update ci-testing.yml * update greetings.yml * bring back os matrix * update ci-testing.yml (ultralytics#3322) * update ci-testing.yml * update greetings.yml * bring back os matrix * Enable direct `--weights URL` definition (ultralytics#3373) * Enable direct `--weights URL` definition @kalenmike this PR will enable direct --weights URL definition. Example use case: ``` python train.py --weights https://storage.googleapis.com/bucket/dir/model.pt ``` * cleanup * bug fixes * weights = attempt_download(weights) * Update experimental.py * Update hubconf.py * return bug fix * comment mirror * min_bytes * Update tutorial.ipynb (ultralytics#3368) add Open in Kaggle badge * `cv2.imread(img, -1)` for IMREAD_UNCHANGED (ultralytics#3379) * Update datasets.py * comment Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> * COCO evolution fix (ultralytics#3388) * COCO evolution fix * cleanup * update print * print fix * Create `is_pip()` function (ultralytics#3391) Returns `True` if file is part of pip package. Useful for contextual behavior modification. ```python def is_pip(): # Is file in a pip package? return 'site-packages' in Path(__file__).absolute().parts ``` * Revert "`cv2.imread(img, -1)` for IMREAD_UNCHANGED (ultralytics#3379)" (ultralytics#3395) This reverts commit 21a9607. * Update FLOPs description (ultralytics#3422) * Update README.md * Changing FLOPS to FLOPs. Co-authored-by: BuildTools <unconfigured@null.spigotmc.org> * Parse URL authentication (ultralytics#3424) * Parse URL authentication * urllib.parse.unquote() * improved error handling * improved error handling * remove %3F * update check_file() * Add FLOPs title to table (ultralytics#3453) * Suppress jit trace warning + graph once (ultralytics#3454) * Suppress jit trace warning + graph once Suppress harmless jit trace warning on TensorBoard add_graph call. Also fix multiple add_graph() calls bug, now only on batch 0. * Update train.py * Update MixUp augmentation `alpha=beta=32.0` (ultralytics#3455) Per VOC empirical results ultralytics#3380 (comment) by @developer0hye * Add `timeout()` class (ultralytics#3460) * Add `timeout()` class * rearrange order * Faster HSV augmentation (ultralytics#3462) remove datatype conversion process that can be skipped * Add `check_git_status()` 5 second timeout (ultralytics#3464) * Add check_git_status() 5 second timeout This should prevent the SSH Git bug that we were discussing @kalenmike * cleanup * replace timeout with check_output built-in timeout * Improved `check_requirements()` offline-handling (ultralytics#3466) Improve robustness of `check_requirements()` function to offline environments (do not attempt pip installs when offline). * Add `output_names` argument for ONNX export with dynamic axes (ultralytics#3456) * Add output names & dynamic axes for onnx export Add output_names and dynamic_axes names for all outputs in torch.onnx.export. The first four outputs of the model will have names output0, output1, output2, output3 * use first output only + cleanup Co-authored-by: Samridha Shrestha <samridha.shrestha@g42.ai> Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> * Revert FP16 `test.py` and `detect.py` inference to FP32 default (ultralytics#3423) * fixed inference bug ,while use half precision * replace --use-half with --half * replace space and PEP8 in detect.py * PEP8 detect.py * update --half help comment * Update test.py * revert space Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> * Add additional links/resources to stale.yml message (ultralytics#3467) * Update stale.yml * cleanup * Update stale.yml * reformat * Update stale.yml HUB URL (ultralytics#3468) * Stale `github.actor` bug fix (ultralytics#3483) * Explicit `model.eval()` call `if opt.train=False` (ultralytics#3475) * call model.eval() when opt.train is False call model.eval() when opt.train is False * single-line if statement * cleanup Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> * check_requirements() exclude `opencv-python` (ultralytics#3495) Fix for 3rd party or contrib versions of installed OpenCV as in ultralytics#3494. * Earlier `assert` for cpu and half option (ultralytics#3508) * early assert for cpu and half option early assert for cpu and half option * Modified comment Modified comment * Update tutorial.ipynb (ultralytics#3510) * Reduce test.py results spacing (ultralytics#3511) * Update README.md (ultralytics#3512) * Update README.md Minor modifications * 850 width * Update greetings.yml revert greeting change as PRs will now merge to master. Co-authored-by: Piotr Skalski <SkalskiP@users.noreply.github.com> Co-authored-by: SkalskiP <piotr.skalski92@gmail.com> Co-authored-by: Peretz Cohen <pizzaz93@users.noreply.github.com> Co-authored-by: tudoulei <34886368+tudoulei@users.noreply.github.com> Co-authored-by: chocosaj <chocosaj@users.noreply.github.com> Co-authored-by: BuildTools <unconfigured@null.spigotmc.org> Co-authored-by: Yonghye Kwon <developer.0hye@gmail.com> Co-authored-by: Sam_S <SamSamhuns@users.noreply.github.com> Co-authored-by: Samridha Shrestha <samridha.shrestha@g42.ai> Co-authored-by: edificewang <609552430@qq.com> (cherry picked from commit f3c3d2c)

* Update datasets.py * comment Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> (cherry picked from commit 21a9607)

ultralytics#3395) This reverts commit 21a9607. (cherry picked from commit fdbe527)

* Update datasets.py * comment Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>

ultralytics#3395) This reverts commit 67db4b6.

@kalenmike

* update ci-testing.yml (ultralytics#3322) * update ci-testing.yml * update greetings.yml * bring back os matrix * update ci-testing.yml (ultralytics#3322) * update ci-testing.yml * update greetings.yml * bring back os matrix * Enable direct `--weights URL` definition (ultralytics#3373) * Enable direct `--weights URL` definition @kalenmike this PR will enable direct --weights URL definition. Example use case: ``` python train.py --weights https://storage.googleapis.com/bucket/dir/model.pt ``` * cleanup * bug fixes * weights = attempt_download(weights) * Update experimental.py * Update hubconf.py * return bug fix * comment mirror * min_bytes * Update tutorial.ipynb (ultralytics#3368) add Open in Kaggle badge * `cv2.imread(img, -1)` for IMREAD_UNCHANGED (ultralytics#3379) * Update datasets.py * comment Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> * COCO evolution fix (ultralytics#3388) * COCO evolution fix * cleanup * update print * print fix * Create `is_pip()` function (ultralytics#3391) Returns `True` if file is part of pip package. Useful for contextual behavior modification. ```python def is_pip(): # Is file in a pip package? return 'site-packages' in Path(__file__).absolute().parts ``` * Revert "`cv2.imread(img, -1)` for IMREAD_UNCHANGED (ultralytics#3379)" (ultralytics#3395) This reverts commit 67db4b6. * Update FLOPs description (ultralytics#3422) * Update README.md * Changing FLOPS to FLOPs. Co-authored-by: BuildTools <unconfigured@null.spigotmc.org> * Parse URL authentication (ultralytics#3424) * Parse URL authentication * urllib.parse.unquote() * improved error handling * improved error handling * remove %3F * update check_file() * Add FLOPs title to table (ultralytics#3453) * Suppress jit trace warning + graph once (ultralytics#3454) * Suppress jit trace warning + graph once Suppress harmless jit trace warning on TensorBoard add_graph call. Also fix multiple add_graph() calls bug, now only on batch 0. * Update train.py * Update MixUp augmentation `alpha=beta=32.0` (ultralytics#3455) Per VOC empirical results ultralytics#3380 (comment) by @developer0hye * Add `timeout()` class (ultralytics#3460) * Add `timeout()` class * rearrange order * Faster HSV augmentation (ultralytics#3462) remove datatype conversion process that can be skipped * Add `check_git_status()` 5 second timeout (ultralytics#3464) * Add check_git_status() 5 second timeout This should prevent the SSH Git bug that we were discussing @kalenmike * cleanup * replace timeout with check_output built-in timeout * Improved `check_requirements()` offline-handling (ultralytics#3466) Improve robustness of `check_requirements()` function to offline environments (do not attempt pip installs when offline). * Add `output_names` argument for ONNX export with dynamic axes (ultralytics#3456) * Add output names & dynamic axes for onnx export Add output_names and dynamic_axes names for all outputs in torch.onnx.export. The first four outputs of the model will have names output0, output1, output2, output3 * use first output only + cleanup Co-authored-by: Samridha Shrestha <samridha.shrestha@g42.ai> Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> * Revert FP16 `test.py` and `detect.py` inference to FP32 default (ultralytics#3423) * fixed inference bug ,while use half precision * replace --use-half with --half * replace space and PEP8 in detect.py * PEP8 detect.py * update --half help comment * Update test.py * revert space Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> * Add additional links/resources to stale.yml message (ultralytics#3467) * Update stale.yml * cleanup * Update stale.yml * reformat * Update stale.yml HUB URL (ultralytics#3468) * Stale `github.actor` bug fix (ultralytics#3483) * Explicit `model.eval()` call `if opt.train=False` (ultralytics#3475) * call model.eval() when opt.train is False call model.eval() when opt.train is False * single-line if statement * cleanup Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> * check_requirements() exclude `opencv-python` (ultralytics#3495) Fix for 3rd party or contrib versions of installed OpenCV as in ultralytics#3494. * Earlier `assert` for cpu and half option (ultralytics#3508) * early assert for cpu and half option early assert for cpu and half option * Modified comment Modified comment * Update tutorial.ipynb (ultralytics#3510) * Reduce test.py results spacing (ultralytics#3511) * Update README.md (ultralytics#3512) * Update README.md Minor modifications * 850 width * Update greetings.yml revert greeting change as PRs will now merge to master. Co-authored-by: Piotr Skalski <SkalskiP@users.noreply.github.com> Co-authored-by: SkalskiP <piotr.skalski92@gmail.com> Co-authored-by: Peretz Cohen <pizzaz93@users.noreply.github.com> Co-authored-by: tudoulei <34886368+tudoulei@users.noreply.github.com> Co-authored-by: chocosaj <chocosaj@users.noreply.github.com> Co-authored-by: BuildTools <unconfigured@null.spigotmc.org> Co-authored-by: Yonghye Kwon <developer.0hye@gmail.com> Co-authored-by: Sam_S <SamSamhuns@users.noreply.github.com> Co-authored-by: Samridha Shrestha <samridha.shrestha@g42.ai> Co-authored-by: edificewang <609552430@qq.com>

Update datasets.py

0450e6d

github-actions bot reviewed May 29, 2021

View reviewed changes

glenn-jocher changed the title ~~Update datasets.py~~ cv2.imread(img, -1) for IMREAD_UNCHANGED May 29, 2021

glenn-jocher changed the title ~~cv2.imread(img, -1) for IMREAD_UNCHANGED~~ cv2.imread(img, -1) for IMREAD_UNCHANGED May 29, 2021

comment

a5074eb

glenn-jocher merged commit 21a9607 into ultralytics:develop May 29, 2021

glenn-jocher added a commit that referenced this pull request May 31, 2021

Revert "cv2.imread(img, -1) for IMREAD_UNCHANGED (#3379)"

82a11ec

This reverts commit 21a9607.

glenn-jocher mentioned this pull request May 31, 2021

Revert "cv2.imread(img, -1) for IMREAD_UNCHANGED" #3395

Merged

glenn-jocher added a commit that referenced this pull request May 31, 2021

Revert "cv2.imread(img, -1) for IMREAD_UNCHANGED (#3379)" (#3395)

fdbe527

This reverts commit 21a9607.

Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021

cv2.imread(img, -1) for IMREAD_UNCHANGED (ultralytics#3379)

533a0d3

* Update datasets.py * comment Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com> (cherry picked from commit 21a9607)

Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021

Revert "cv2.imread(img, -1) for IMREAD_UNCHANGED (ultralytics#3379)" (

557526e

ultralytics#3395) This reverts commit 21a9607. (cherry picked from commit fdbe527)

glenn-jocher mentioned this pull request Oct 12, 2021

YOLOv5 release v6.0 #5141

Merged

glenn-jocher mentioned this pull request Nov 7, 2021

YOLOv5 v6.0 compatibility update (draft) ultralytics/yolov3#1855

Closed

glenn-jocher mentioned this pull request Nov 14, 2021

YOLOv5 v6.0 compatibility update ultralytics/yolov3#1857

Merged

BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022

cv2.imread(img, -1) for IMREAD_UNCHANGED (ultralytics#3379)

67db4b6

* Update datasets.py * comment Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>

BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022

Revert "cv2.imread(img, -1) for IMREAD_UNCHANGED (ultralytics#3379)" (

85f90f6

ultralytics#3395) This reverts commit 67db4b6.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

`cv2.imread(img, -1)` for IMREAD_UNCHANGED#3379

`cv2.imread(img, -1)` for IMREAD_UNCHANGED#3379
glenn-jocher merged 2 commits intoultralytics:developfrom
tudoulei:patch-1

tudoulei commented May 29, 2021 •

edited by UltralyticsAssistant

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

glenn-jocher commented May 29, 2021

Uh oh!

glenn-jocher commented May 29, 2021

Uh oh!

glenn-jocher commented May 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

tudoulei commented May 29, 2021 • edited by UltralyticsAssistant Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛠️ PR Summary

🌟 Summary

📊 Key Changes

🎯 Purpose & Impact

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

glenn-jocher commented May 29, 2021

Uh oh!

glenn-jocher commented May 29, 2021

Uh oh!

glenn-jocher commented May 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tudoulei commented May 29, 2021 •

edited by UltralyticsAssistant

Loading