Adjust legend labels for classes without instances#5174
Merged
glenn-jocher merged 4 commits intoultralytics:masterfrom Oct 14, 2021
Merged
Adjust legend labels for classes without instances#5174glenn-jocher merged 4 commits intoultralytics:masterfrom
glenn-jocher merged 4 commits intoultralytics:masterfrom
Conversation
Contributor
Author
Contributor
Author
|
@glenn-jocher For future reference, how do you feel about incrementally introducing typing? Would make understanding the code more rapid and development easier. E.g. from typing import List, Dict
def plot_pr_curve(
px: np.ndarray,
py: np.ndarray,
ap: List[float],
save_dir: str='pr_curve.png',
names: Dict={}
):
|
Member
|
@NauchtanRobotics thanks for the PR! Would this simplified version also work? names = [v for k, v in names.items() if k in unique_classes] # list of unique names
names = {i: v for i, v in enumerate(names)} # to dictYes, typing is one of the options we are considering for improving the codebase, but for consistency we'd probably want to apply formatting updates across the whole repo, so let's leave it off the plate for now. Thanks! |
Contributor
Author
|
Yes, that works a treat @glenn-jocher. See all 4 affected charts. |
Member
|
@NauchtanRobotics PR is (squashed and) merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐ |
Merged
BjarneKuehl
pushed a commit
to fhkiel-mlaip/yolov5
that referenced
this pull request
Aug 26, 2022
* legend-labels Adjust legend labels for classes without instances. * ultralytics#5158 Re-indexed series names: only classes containing data. * ultralytics#5158 Re-indexed series names: only classes containing data. * Cleanup Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





See issue #5158
Before
PR Curve legend has labels for "D00" and "D10" but should have labels for "D40" and "EB".
D00 and D10 have no bounding box instances, and no predictions.
'stats' omits classes that have len = 0; therefore 'names' should also omit empty classes.
:
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improved class naming handling in precision-recall and F1 score calculations and plots.
📊 Key Changes
🎯 Purpose & Impact