Conversation
Fix incorrect TGT (target end time) calculation in presence of non-work gaps. Previously, TGT was computed as `first_in + expected_work_time`, ignoring personal absences (non-work gaps), causing inconsistencies with ΔWORK. Updated logic: - TGT now includes non-work gaps: TGT = first_in + expected_work_time + non_work_gaps - ΔWORK is now consistently calculated as: ΔWORK = OUT - TGT - Removed implicit subtraction of non-work gaps to avoid double counting Applied changes to: - standard list output - compact list output Also updated documentation: - CHANGELOG.md with fix details and example - README.md to clarify TGT behavior No changes to core work time calculation or database schema. Closes #43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect TGT (target end time) calculation in presence of non-work gaps. Previously, TGT was computed as
first_in + expected_work_time, ignoring personal absences (non-work gaps), causing inconsistencies with ΔWORK.Updated logic:
Applied changes to:
Also updated documentation:
No changes to core work time calculation or database schema.
Closes #43