make rasters work with products that cross antimeridian#271
Conversation
|
remark : the footprint in dataset.attrs will be defined from longitudes in [-180;180], so the Polygon is not good. The footprint comes from Note that if we apply At the moment we decide to keep the |
agrouaze
left a comment
There was a problem hiding this comment.
No remarks on the code itself.
But on the PR, can you:
- describe the scope of the PR (is it for RS2, RMC and S1?, what was the status before this PR? why ECMWF raster is impacted?)
- can you add a unit test with a real product crossing the anti meridian or a
mockproduct? - can you confirm
sphinxcompiles successfully - can you confirm
pytestare successful
|
files concerned are files that cross the antimeridian (RS2/RCM/S1). Before the PR, an error was generated. |
|
https://github.com/umr-lops/mapraster will make map_raster out of |
|
I agree that adding a (or several) unit test for the specific case of anti-meridian crossing is a good idea ! |
|
@agrouaze doc OK |
|
just waiting for the conda version of 'mapraster' |
|
@agrouaze @oceanscoper mapraster is now on conda-forge. could you validate this PR? |
files concerned are files that cross the antimeridian (RS2/RCM/S1). Before the PR, an error was generated.
rasters are concerned because there is an operation of mapping the raster on the grid, it requires continuity.