Skip to content

CLDR-18351 fail better: for site and spec deploy#4489

Merged
srl295 merged 1 commit intounicode-org:mainfrom
srl295:cldr-18351/fail-better
Mar 12, 2025
Merged

CLDR-18351 fail better: for site and spec deploy#4489
srl295 merged 1 commit intounicode-org:mainfrom
srl295:cldr-18351/fail-better

Conversation

@srl295
Copy link
Member

@srl295 srl295 commented Mar 11, 2025

  • if you open a site PR from a fork for the site, give a warning instead of failing.
  • if you merge to a branch that can't deploy to gh-pages, skip deploy instead of fail

CLDR-18351

  • This PR completes the ticket.

Review Notes:

  • site: verify that a PR from a fork doesn't error (it won't label either)
  • site: once merged, verify that a PR from the head fork deploys ok
  • spec: once merged, verify that main deploys OK
  • spec: once merged, verify that a merge to a branch no longer fails GH-pages

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Mar 11, 2025
@srl295 srl295 force-pushed the cldr-18351/fail-better branch from cbff4d3 to d680f59 Compare March 11, 2025 22:03
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/site.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/site.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/site.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 force-pushed the cldr-18351/fail-better branch from 50bab66 to d1d3571 Compare March 11, 2025 22:18
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/site.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

- if you open a site PR from a fork for the site, skip deploy instead of fail
      we can't send a message easily from there.

- if you merge to a branch that can't deploy to gh-pages, skip deploy instead of fail
@srl295 srl295 force-pushed the cldr-18351/fail-better branch from d1d3571 to a75ae0f Compare March 11, 2025 22:23
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/site.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295
Copy link
Member Author

srl295 commented Mar 12, 2025

Note: I put review notes on this PR, but they are for after it merges.

@srl295 srl295 merged commit 2df2456 into unicode-org:main Mar 12, 2025
10 checks passed
@srl295 srl295 deleted the cldr-18351/fail-better branch March 12, 2025 14:52
@srl295 srl295 mentioned this pull request Mar 12, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants