Skip to content

CLDR-18356 st: unvendor fonts#4507

Merged
srl295 merged 2 commits intounicode-org:mainfrom
srl295:deps/cldr-18356/unvendor-fonts
Mar 19, 2025
Merged

CLDR-18356 st: unvendor fonts#4507
srl295 merged 2 commits intounicode-org:mainfrom
srl295:deps/cldr-18356/unvendor-fonts

Conversation

@srl295
Copy link
Member

@srl295 srl295 commented Mar 18, 2025

  • remove fonts from repo
  • add via NPM

CLDR-18356

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

- remove fonts from repo
- add via NPM
@srl295 srl295 force-pushed the deps/cldr-18356/unvendor-fonts branch from daf6b36 to e86da57 Compare March 18, 2025 16:04
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tools/cldr-apps/js/package-lock.json is different
  • tools/cldr-apps/js/package.json is different
  • tools/cldr-apps/js/src/index.js is now changed in the branch
  • tools/cldr-apps/js/webpack.config.js is now changed in the branch
  • tools/cldr-apps/src/main/webapp/surveytool.css is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 added the dependencies Pull requests that update a dependency file label Mar 18, 2025
- minor updates to font inclusion
@srl295 srl295 requested a review from btangmu March 18, 2025 20:10
@srl295 srl295 marked this pull request as ready for review March 18, 2025 20:10
@srl295 srl295 requested a review from markusicu March 18, 2025 20:11
@srl295
Copy link
Member Author

srl295 commented Mar 18, 2025

Confirmed that this works locally.

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@srl295 srl295 merged commit 81e190d into unicode-org:main Mar 19, 2025
13 checks passed
@srl295 srl295 deleted the deps/cldr-18356/unvendor-fonts branch March 19, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants