Conversation
Member
Author
|
PS Filed a ticket for improvements to the tooling, to make it easier to add structure. |
btangmu
approved these changes
Mar 24, 2025
Member
btangmu
left a comment
btangmu
left a comment
There was a problem hiding this comment.
This makes my head spin. +1 ½ for extensive tests
| + ".\n" | ||
| + "^//ldml/numbers/rationalFormats/integerAndRationalPattern\\[@alt=\"([^\"]*)\"]" | ||
| + RegexLookup.SEPARATOR | ||
| + "A pattern that is used to “glue” an integer and a formatted rational fraction (eg, ½) together; only used when the rational fraction does not start with an un-superscripted digit" |
Member
There was a problem hiding this comment.
"does not start with an un-superscripted digit" -- meaning (1) it does start with a superscripted digit, or (2) it starts with a non-digit? If it starts with a non-digit, would it be something like "one/half"? Just curious...
Member
Author
There was a problem hiding this comment.
Formally https://util.unicode.org/UnicodeJsps/list-unicodeset.jsp?a=%5Cp%7Bgc%3DNd%7D, we'll need to explain it. Once we have markdown in examples, it would be easy to link out to an explanation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLDR-17570
Add new structure for rationals; put them with the rest of the number formats (decimal, scientific, etc.).
This involved various other changes:
root and en and dtd
Placeholder additions
DAIP additions
ExampleGenerator additions
Note that often new structure needs Checks, but this uses DAIP for two cases that would otherwise be errors.
This PR completes the ticket.
ALLOW_MANY_COMMITS=true