Skip to content

CLDR-17959 Rename classes whose names collide#4528

Merged
btangmu merged 1 commit intounicode-org:mainfrom
btangmu:t17959_a
Mar 25, 2025
Merged

CLDR-17959 Rename classes whose names collide#4528
btangmu merged 1 commit intounicode-org:mainfrom
btangmu:t17959_a

Conversation

@btangmu
Copy link
Member

@btangmu btangmu commented Mar 25, 2025

-Rename 11 classes as proposed in the ticket

CLDR-17959

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

-Rename 11 classes as proposed in the ticket
@btangmu btangmu self-assigned this Mar 25, 2025
@btangmu btangmu requested a review from srl295 March 25, 2025 16:40
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, if it reduces confusion.

@btangmu
Copy link
Member Author

btangmu commented Mar 25, 2025

Looks fine, if it reduces confusion.

Yes, I think the confusion was already discussed when the ticket was accepted. An example is that error/warning messages in various contexts refer to class/file names, and when you search for such a class/file, more than one possibility comes up, and (for me at least) it wastes time and mental energy to notice the ambiguity and figure out how to disambiguate.

@btangmu btangmu merged commit 10e0994 into unicode-org:main Mar 25, 2025
13 checks passed
@btangmu btangmu deleted the t17959_a branch March 25, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants