CLDR-18575 Drop /index from site paths#5370
CLDR-18575 Drop /index from site paths#5370aryanraj45 wants to merge 1 commit intounicode-org:mainfrom
Conversation
|
hii @srl295 can u please take a look on this whenever your free and let me know if there any changes required thanks! |
|
@AEApple seems reasonable. Probably mostly a question of timing. |
|
▶ Run sh tools/scripts/web/build-site.sh This is failing. |
|
Steven, I found the cause of the build failure. The build-site.sh script was failing because sitemap.tsv still contained references to the old /index/* paths. |
493bfec to
ca4628e
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
@srl295 I have updated the commit the local build is now passing successfully with build-site.sh ,Could you please take a look or trigger the workflow? Thanks! |
|
We could split this into two PRs - one just adding the redirect and renaming the files that need rename. It will work, but the links will have a redirect. The second PR could fixup the /index links. This would let us reduce the risk of conflicts. @aryanraj45 please run the build script i mentioned, the .tsv needs to be updated when files are moved. |
|
@srl295 Understood the changes, that makes sense. I will split this work into two separate PRs as you suggested one for renaming the files and another for the /index links Also prior to this I have already updated the sitemap.tsv and verified the build locally, which is why the build is now successful here in the github as well and successfully deployed to cloudflare |
- Renamed 32 files from docs/site/index/* to docs/site/* - Updated _redirects with catch-all rule: /index/* -> /:splat - Updated sitemap.tsv to reflect new file paths - Site now works via redirects (link fixes in separate PR)
ca4628e to
a59e1a0
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
@srl295 I have updated this PR to follow your suggestion. This PR now contains only:
The markdown link fixes will be in a separate PR to reduce conflict risk as you suggested. Please have a look, thanks! |
|
@aryanraj45 thank you. Note that most importantly we need to discuss when to make this change. |
|
@srl295 No worries, totally understand that changing URLs is a big move and needs proper coordination and timing with the team. |
CLDR-18575 Drop /index from site paths
This PR completes the ticket
ALLOW_MANY_COMMITS=true