CLDR-19258 Fix datetime test data to use all four dateTimeFormat lengths#5402
Merged
sffc merged 1 commit intounicode-org:mainfrom Feb 26, 2026
Merged
CLDR-19258 Fix datetime test data to use all four dateTimeFormat lengths#5402sffc merged 1 commit intounicode-org:mainfrom
sffc merged 1 commit intounicode-org:mainfrom
Conversation
echeran
previously approved these changes
Feb 25, 2026
Contributor
echeran
left a comment
echeran
left a comment
There was a problem hiding this comment.
LGTM.
From Shane:
Calendar.getDateTimePatternwas always wrong because it is an ICU4J function loading from ICU4J data
This fixes that to load from theCLDRFile, and also to populate all four lengths
sffc
force-pushed
the
CLDR-19258-oldcodefix
branch
from
cd8929f to
cb7755c
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Contributor
|
FYI, the CLA CI check got stuck, so I used the magic URL to restart it: http://cla-assistant.io/check/unicode-org/cldr?pullRequest=5402 |
echeran
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLDR-19258
This is a small change to the existing datetime datagen code in order to make the new code have a clean diff.
ALLOW_MANY_COMMITS=true