CLDR-18832 Add singular cardinal rules and ordinal rules for Slovenian#5407
Open
grhoten wants to merge 1 commit intounicode-org:mainfrom
Open
CLDR-18832 Add singular cardinal rules and ordinal rules for Slovenian#5407grhoten wants to merge 1 commit intounicode-org:mainfrom
grhoten wants to merge 1 commit intounicode-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLDR-18832
This pull request includes most of the changes from the proposed changes from this ticket. It excludes the dual and plural cardinal rules, since it was conceptually hard to verify, and the provided rules were too incomplete to use. Most of the ordinal rules were included, but if there were scenarios where the gender or grammatical number didn't affect the ordinal rule choice, I just collapsed them to one rule.
If the plural or dual cardinal rules are still desired, I recommend submitting a separate ticket, and making a contribution on top of these rules, which has roundtrippable simpler rules. As it stands, I could not validate or cross reference such information from what I could find online, and these rules are complicated enough.
The provided rules from the ticket did not roundtrip correctly. It had many gaps in the rules. These rules do roundtrip. In order to roundtrip, the latest rule syntax from ICU must be used, like the kind that are already in Polish and Lithuanian. I replaced all of the contributed rules that were 100 and larger with this syntax.
I used the soft hyphen for the ordinals. Some of the other languages use a soft hyphen to allow better line wrapping of long ordinals.
I did not redundantly transform these to the old RBNF XML syntax, and these rules use the latest rule format, which will should be going into CLDR 49. This should not be merged into CLDR 48 or earlier.
ALLOW_MANY_COMMITS=true