Add deadletter queue for causal diffs #169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A recently submitted contribution included references to unknown builtins, this caused the contribution diff to crash, but the queue didn't have any error handling, so it would keep retrying without backoff and ended up gumming up the diff queue and also using up all our Postgres credits :'(
This adds error handling which should catch invalid diffs and mark them as errors so they're not retried.
Implementation notes
Test coverage
I'll test one known invalid diff on production to ensure it's all working correctly.
Loose ends
I'd prefer we had a proper queueing solution; ideally one with auto-backoff, a GUI interface, and maybe even some form of alerting. Maybe we can look at adding one.