feat: support logical and member expression#111
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 93.54% 93.53% -0.02%
==========================================
Files 25 27 +2
Lines 1797 1855 +58
Branches 335 341 +6
==========================================
+ Hits 1681 1735 +54
- Misses 115 119 +4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
antfu
approved these changes
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
N/A
❓ Type of change
📚 Description
This PR adds support for logical and member expression, allowing for that kind of code modification with
builder.raw()(which would have thrown aMagicastErrorbefore)I'm by far not an AST expert so I'm not sure if my changes cover it all. Also I'm not sure if this kind of node support is welcome/within the scope of Magicast, so let me know if not, no big deal☺️
On another note, I feel like there's a pattern here, maybe we want to support other node types like conditional expressions (
foo ? bar : baz) with some kind of generic proxy instead for "readonly" kind of node. Feel free to nudge me towards the direction that fits better the project!Thanks!
📝 Checklist