Replace Set with Collection in SoundRegistry#40
Merged
yusshu merged 1 commit intounnamed:ver/1.x.xfrom Dec 31, 2023
Merged
Conversation
Member
|
Instead of changing the old methods, this should add new methods (don't mark the old ones as deprecated), so backwards-compatibility is kept. Also note that |
Contributor
Author
|
Replacing Set with Collection will not break backward compatibility since Set inherits Collection |
Member
|
It breaks already compiled code, as it changes the method signature |
MelonHell
force-pushed
the
pr/sound-registry-set-to-collection
branch
from
61b668d to
6f5f7e0
Compare
yusshu
reviewed
Dec 29, 2023
MelonHell
force-pushed
the
pr/sound-registry-set-to-collection
branch
from
6f5f7e0 to
fe00de1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #38