Open
Conversation
…actoring across project.
haarchri
reviewed
Dec 11, 2025
| @@ -0,0 +1,96 @@ | |||
| import models.io.crossplane.helm.v1alpha1 as helmv1alpha1 | |||
Member
There was a problem hiding this comment.
can you cleanup the unused ones ?
haarchri
reviewed
Dec 11, 2025
| route53zoneId = "Z0115025YFQ7ZQF6BJ6N" | ||
| version = "1.34" | ||
| iam = { | ||
| roleArn = "arn:aws:iam::609897127049:role/AWSReservedSSO_AdministratorAccess_d703c73ed340fde7" |
Member
There was a problem hiding this comment.
can we put this behind an ENV variable ?
haarchri
reviewed
Dec 11, 2025
| instanceType = "t3.small" | ||
| } | ||
| region = "eu-west-1" | ||
| route53zoneId = "Z0115025YFQ7ZQF6BJ6N" |
haarchri
reviewed
Dec 11, 2025
| # route53zoneId: Z0000000000000000000 | ||
| route53zoneId: Z0115025YFQ7ZQF6BJ6N | ||
| iam: | ||
| roleArn: arn:aws:iam::609897127049:role/AWSReservedSSO_AdministratorAccess_d703c73ed340fde7 |
Member
There was a problem hiding this comment.
think we should add an placeholder here
haarchri
reviewed
Dec 11, 2025
| # The route53zoneId is crucial for making the CNOE platform accessible via a web browser. | ||
| # Replace the placeholder below with your Route53 Zone ID. | ||
| # route53zoneId: Z0000000000000000000 | ||
| route53zoneId: Z0115025YFQ7ZQF6BJ6N |
haarchri
reviewed
Dec 11, 2025
Member
haarchri
left a comment
There was a problem hiding this comment.
can you share a bit that CNOE is still working, login and capture some screens ? are we using the same charts / images than upstream CNOE ? when we removed bitnami ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Changes #
Usagefor deletion ordering.Cleanup #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested