Fix/storage tables missing identity#147
Open
antonp-semperis wants to merge 3 commits intoupbound:mainfrom
Open
Fix/storage tables missing identity#147antonp-semperis wants to merge 3 commits intoupbound:mainfrom
antonp-semperis wants to merge 3 commits intoupbound:mainfrom
Conversation
…ources Azure Storage Tables API (Microsoft.Storage/storageAccounts/tableServices/tables) and some other nested resources don't return the standard ARM 'id' field in their API response. This causes upjet's IDAsExternalName to fail with 'cannot find id in tfstate' error, which surfaces as 'Missing Resource Identity After Read'. This fix overrides GetExternalNameFn to fall back to constructing the resource identity from parent_id + name when the id field is missing or empty. Fixes: Missing Resource Identity After Read error for storage tables
…Identity incompatibility The terraform-provider-azapi v2.8.0 introduced support for Terraform 1.12's ResourceWithIdentity interface. However, upjet does not implement this interface, causing 'Missing Resource Identity After Read' errors when managing resources like Azure Storage Tables. This commit downgrades to terraform-provider-azapi v2.7.0-upjet.1 which does not implement ResourceWithIdentity, allowing the provider to work correctly with upjet. Fixes: Storage Tables fail with 'Missing Resource Identity After Read' error
antonp-semperis
requested review from
erhancagirici,
sergenyalcin,
turkenf and
ulucinar
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: downgrade terraform-provider-azapi to v2.7.0 to fix ResourceWithIdentity incompatibility
Problem
The terraform-provider-azapi v2.8.0 introduced support for Terraform 1.12's
ResourceWithIdentityinterface. However, upjet does not implement this interface, causing 'Missing Resource Identity After Read' errors when managing resources like Azure Storage Tables.Error
Root Cause
ResourceWithIdentityinterface (Terraform Plugin Framework)ResourceWithIdentity- it has stub implementations that panicSolution
Downgrade to terraform-provider-azapi v2.7.0-upjet.1 which does not implement
ResourceWithIdentity, allowing the provider to work correctly with upjet.Testing
Verified that Azure Storage Tables now create/update/delete correctly with full management policies.
Related
server_readresource.go:203-210