Skip to content

feat(scripting): allow multiple script context roots in response scripts#1397

Merged
helloanoop merged 1 commit intousebruno:mainfrom
carlosflorencio:feature/respose-script-additionalcontext
Apr 2, 2025
Merged

feat(scripting): allow multiple script context roots in response scripts#1397
helloanoop merged 1 commit intousebruno:mainfrom
carlosflorencio:feature/respose-script-additionalcontext

Conversation

@carlosflorencio
Copy link
Copy Markdown
Contributor

@carlosflorencio carlosflorencio commented Jan 16, 2024

Description

Same as #795 but adding the functionality to the response scripts as well.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@carlosflorencio carlosflorencio marked this pull request as ready for review January 16, 2024 14:44
@tlaloc911
Copy link
Copy Markdown
Contributor

@carlosflorencio , is there any open issue related to this PR?

@carlosflorencio
Copy link
Copy Markdown
Contributor Author

@tlaloc911 I don't think so.

@tlaloc911
Copy link
Copy Markdown
Contributor

thanks @carlosflorencio , I created #1729 to reflect this need as an open issue

@tlaloc911
Copy link
Copy Markdown
Contributor

hi @helloanoop , could you consider to accept this PR? The previous PR #795 resolved just the pre-request section, post response script still doesn't have posibility to use aditional roots. Thanks!

@orached
Copy link
Copy Markdown

orached commented Apr 4, 2024

Can you please include this fix in the next release?

@sanjai0py sanjai0py added the enhancement New feature or request label Apr 5, 2024
@Frankenleg
Copy link
Copy Markdown

This PR has been open for 5 months... Why is it taking so long to get merged? Is there an issue with the fix?

@centur
Copy link
Copy Markdown

centur commented Aug 28, 2024

bump. Would be nice to merge this if it fixes #2942 , as from usability perspective - this clearly looks like a bug.
cc @helloanoop

@centur
Copy link
Copy Markdown

centur commented Aug 30, 2024

@carlosflorencio 🐳 ship it! 🎉

@carlosflorencio
Copy link
Copy Markdown
Contributor Author

@centur I can't, needs to be merged by someone with write access 😅.

@centur
Copy link
Copy Markdown

centur commented Sep 3, 2024

@lohxt1 or @helloanoop Would you mind merging this nice fix ?

@RohitRox
Copy link
Copy Markdown

What's the hold up?! Can we have this fix on next release plz.

@helloanoop
Copy link
Copy Markdown
Contributor

Sorry folks. Merging this for the upcoming release.

@lohxt1 please review and test these changes.

@hadarnexus
Copy link
Copy Markdown

hadarnexus commented Mar 30, 2025

Hey @anusree-bruno / @lohxt1 , any idea when this will be merged?

@anusree-bruno
Copy link
Copy Markdown
Collaborator

@hadarnexus
This will be available in the next release

@helloanoop helloanoop merged commit 0591530 into usebruno:main Apr 2, 2025
@helloanoop
Copy link
Copy Markdown
Contributor

Merged PR. This will be released in v2.1.0 scheduled to go out on Fri 4 Apr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.