Skip to content

ca certs fixes and tests#5429

Merged
lohit-bruno merged 3 commits intousebruno:mainfrom
lohit-bruno:ca_certs_fixes
Sep 7, 2025
Merged

ca certs fixes and tests#5429
lohit-bruno merged 3 commits intousebruno:mainfrom
lohit-bruno:ca_certs_fixes

Conversation

@lohit-bruno
Copy link
Copy Markdown
Collaborator

@lohit-bruno lohit-bruno commented Aug 26, 2025

jira

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Copy link
Copy Markdown
Contributor

@helloanoop helloanoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lohit-bruno @bijin-bruno

These are critical changes. Lets get a e2e test in that validates the functionality of using custom certs that have been added to the keychain.

@lohit-bruno lohit-bruno force-pushed the ca_certs_fixes branch 4 times, most recently from 0c1c9e7 to ca2f37c Compare September 3, 2025 21:58
@lohit-bruno lohit-bruno changed the title include system and extra ca certs with the default certs ca certs fixes and tests Sep 3, 2025
@lohit-bruno lohit-bruno force-pushed the ca_certs_fixes branch 9 times, most recently from 541e974 to 850908a Compare September 4, 2025 10:15
@lohit-bruno lohit-bruno force-pushed the ca_certs_fixes branch 18 times, most recently from 1500453 to 3db165b Compare September 7, 2025 13:07
@helloanoop
Copy link
Copy Markdown
Contributor

@lohit-bruno As discussed, please make the ssl tests run together and go ahead with merging this PR.

@helloanoop
Copy link
Copy Markdown
Contributor

Nice work @lohit-bruno 👏 👏 ❤️
Please squash merge.

@lohit-bruno lohit-bruno merged commit 3c65627 into usebruno:main Sep 7, 2025
7 checks passed
lohit-bruno added a commit to lohit-bruno/bruno that referenced this pull request Sep 7, 2025
Co-authored-by: Anoop M D <anoop.md1421@gmail.com>
naman-bruno pushed a commit to naman-bruno/bruno that referenced this pull request Sep 8, 2025
Co-authored-by: Anoop M D <anoop.md1421@gmail.com>
pooja-bruno pushed a commit to pooja-bruno/bruno that referenced this pull request Sep 11, 2025
Co-authored-by: Anoop M D <anoop.md1421@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants