fix(dependencies): update fast-xml-parser to 5.5.7 and simple-git to …#7602
fix(dependencies): update fast-xml-parser to 5.5.7 and simple-git to …#7602bijin-bruno merged 3 commits intousebruno:mainfrom
Conversation
…3.32.3; add path-expression-matcher and fast-xml-builder
There was a problem hiding this comment.
Pull request overview
Updates dependencies as part of a “Critical Dependency Update Check” across the monorepo workspaces, primarily targeting XML parsing and git integration used by testbench and Electron app packages.
Changes:
- Bump
fast-xml-parserin@usebruno/teststo^5.5.7. - Bump
simple-gitinbruno-electronto3.32.3. - Add root-level npm
overridesforfast-xml-parserandpbkdf2, with correspondingpackage-lock.jsonupdates.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/bruno-tests/package.json | Updates fast-xml-parser version used by the testbench server utilities. |
| packages/bruno-electron/package.json | Updates simple-git version used by the Electron app’s git utilities. |
| package.json | Adds/adjusts root overrides for dependency pinning. |
| package-lock.json | Lockfile changes reflecting updated dependency graph (including new transitive deps). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdated dev tooling and runtime dependency versions across the monorepo; replaced usages of Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/bruno-tests/package.json (1)
29-29: Consider exact-pinningfast-xml-parserfor consistency with root overrides.Root-level
overridesdon't apply when this workspace package is installed independently. The caret range^5.5.7can drift outside the monorepo's pinned version5.5.7, risking inconsistent behavior. Exact-pin to5.5.7for deterministic dependency resolution.Proposed change
- "fast-xml-parser": "^5.5.7", + "fast-xml-parser": "5.5.7",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/bruno-tests/package.json` at line 29, Update the fast-xml-parser dependency in this workspace package's package.json to an exact version to match root overrides: replace the caret range for the "fast-xml-parser" entry (currently "^5.5.7") with the exact pinned version "5.5.7" so the package installs deterministically when used outside the monorepo.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Around line 96-98: package-lock.json does not reflect the intended overrides
for fast-xml-parser (5.5.7) and pbkdf2 (3.1.5); remove package-lock.json, verify
the override entries for "fast-xml-parser" and "pbkdf2" in package.json are
correctly formatted for your npm version (or use npm's "overrides" field), then
run a fresh install (npm install) to regenerate the lockfile and confirm
package-lock.json now contains fast-xml-parser@5.5.7 and pbkdf2@3.1.5; if issues
persist, run npm ls fast-xml-parser and npm ls pbkdf2 to find which packages are
pulling older versions and add/rescope overrides accordingly.
---
Nitpick comments:
In `@packages/bruno-tests/package.json`:
- Line 29: Update the fast-xml-parser dependency in this workspace package's
package.json to an exact version to match root overrides: replace the caret
range for the "fast-xml-parser" entry (currently "^5.5.7") with the exact pinned
version "5.5.7" so the package installs deterministically when used outside the
monorepo.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 56f3351a-f66b-4330-9f00-159aec1a3dd9
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
package.jsonpackages/bruno-electron/package.jsonpackages/bruno-tests/package.json
Description
Critical Dependency Update Check
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
Summary by CodeRabbit