Skip to content

fix: isJson assertion should accept arrays as valid JSON #7620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bijin-bruno merged 2 commits into from
Apr 2, 2026
+30 −6
Merged

fix: isJson assertion should accept arrays as valid JSON #7620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5301b71
fix(assert-runtime): update JSON validation to allow arrays and enhan…
abhishek-bruno Mar 30, 2026
6f88960
fix(assert-runtime): refine JSON validation logic to correctly handle…
abhishek-bruno Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/bruno-js/src/runtime/assert-runtime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ chai.use(function (chai, utils) {
// Objects created inside Node's vm.createContext() have a different Object constructor,
// so obj.constructor === Object fails for objects passed via res.setBody() from scripts.
// Note: toString check is more permissive than constructor check — custom class instances
const isJson = typeof obj === 'object' && obj !== null && !Array.isArray(obj)
&& Object.prototype.toString.call(obj) === '[object Object]';
const isJson = typeof obj === 'object' && obj !== null
&& (Array.isArray(obj) || Object.prototype.toString.call(obj) === '[object Object]');

this.assert(isJson, `expected ${utils.inspect(obj)} to be JSON`, `expected ${utils.inspect(obj)} not to be JSON`);
});
Expand Down
4 changes: 2 additions & 2 deletions packages/bruno-js/src/sandbox/quickjs/shims/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ const addBruShimToContext = (vm, __brunoTestResults) => {
Object.defineProperty(proto, 'json', {
get: function () {
var obj = this._obj;
var isJson = typeof obj === 'object' && obj !== null && !Array.isArray(obj) &&
Object.prototype.toString.call(obj) === '[object Object]';
var isJson = typeof obj === 'object' && obj !== null &&
(Array.isArray(obj) || Object.prototype.toString.call(obj) === '[object Object]');
this.assert(isJson, 'expected #{this} to be JSON', 'expected #{this} not to be JSON');
return this;
},
Expand Down
28 changes: 26 additions & 2 deletions packages/bruno-js/tests/runtime.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,12 +317,36 @@ describe('runtime', () => {
expect(results[0].status).toBe('pass');
});

it('should fail for an array', () => {
it('should pass for an array', () => {
const results = runAssertions(
[{ name: 'res.body', value: 'isJson', enabled: true }],
makeResponse([1, 2, 3])
);
expect(results[0].status).toBe('fail');
expect(results[0].status).toBe('pass');
});

it('should pass for an array of strings', () => {
const results = runAssertions(
[{ name: 'res.body', value: 'isJson', enabled: true }],
makeResponse(['A55001213ZX0A'])
);
expect(results[0].status).toBe('pass');
});

it('should pass for an empty array', () => {
const results = runAssertions(
[{ name: 'res.body', value: 'isJson', enabled: true }],
makeResponse([])
);
expect(results[0].status).toBe('pass');
});

it('should pass for an array of objects', () => {
const results = runAssertions(
[{ name: 'res.body', value: 'isJson', enabled: true }],
makeResponse([{ id: 1 }, { id: 2 }])
);
expect(results[0].status).toBe('pass');
});

it('should fail for a string', () => {
Expand Down
Loading