Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughRoot Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Pins axios dependency specifications across several workspaces to reduce exposure to unexpected upstream releases, in response to a reported axios supply-chain incident.
Changes:
- Replace axios caret ranges (
^...) with exact versions in multiple workspacepackage.jsonfiles. - Add a root-level
overridesentry for axios. - Update
package-lock.jsonto reflect the new dependency specs/resolutions.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/bruno-tests/package.json | Pins axios to an exact version for the testbench package. |
| packages/bruno-requests/package.json | Pins axios to an exact version for the requests package. |
| packages/bruno-js/package.json | Pins axios to an exact version for the JS package. |
| packages/bruno-electron/package.json | Pins axios to an exact version for the Electron package. |
| packages/bruno-cli/package.json | Pins axios to an exact version for the CLI package. |
| package.json | Adds a repo-level axios override constraint. |
| package-lock.json | Lockfile updates corresponding to the new pin/override behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 96: Replace the ranged security pin for the axios dependency
("axios":"<=1.13.2") with an exact version pin to prevent version drift; update
the package.json dependency entry for "axios" to a single, exact version string
(e.g., "1.13.2") so installs are deterministic and the supply-chain fix cannot
be bypassed by newer versions.
In `@packages/bruno-requests/package.json`:
- Line 27: The repo has mixed axios versions (packages/bruno-requests pins
"axios": "1.9.0" while CLI packages use 1.8.3), causing the CLI to load two
different axios builds used by makeAxiosInstance (local) and
makeAxiosInstanceForOauth2 (from `@usebruno/requests`); update package dependency
resolution so both sides use the same axios version (preferably 1.9.0), e.g.,
change packages/bruno-requests package.json to the unified version or bump the
CLI packages to 1.9.0, then regenerate the lockfile (npm/yarn/pnpm) to ensure a
single axios is installed and verify behavior of makeAxiosInstance and
makeAxiosInstanceForOauth2 still matches expected multipart/header/fetch error
handling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bdb29b1f-4240-448a-8533-7078d0e04473
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (6)
package.jsonpackages/bruno-cli/package.jsonpackages/bruno-electron/package.jsonpackages/bruno-js/package.jsonpackages/bruno-requests/package.jsonpackages/bruno-tests/package.json
Description
Pin axios versions in CLI for the recent axios npm supply chain attack
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
Summary by CodeRabbit