Skip to content

fix: update system proxy fetching to use finally #7652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bijin-bruno merged 2 commits into from
Apr 1, 2026
+12 −4
Merged

fix: update system proxy fetching to use finally #7652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2364c30
fix: update system proxy fetching to use finally for improved reliabi…
sid-bruno Apr 1, 2026
a6b658b
Update packages/bruno-electron/src/index.js
sid-bruno Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions packages/bruno-electron/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,11 +202,18 @@ app.on('ready', async () => {

// Initialize system proxy cache early (non-blocking)
const { fetchSystemProxy } = require('./store/system-proxy');
waitForShellEnv().then(() => {
fetchSystemProxy().catch((err) => {
console.warn('Failed to initialize system proxy cache:', err);

// Note: irrespective of the state of the shell,
// try to fetch the system proxy information
waitForShellEnv()
.catch((err) => {
console.warn('Shell env init failed:', err);
})
.finally(() => {
fetchSystemProxy().catch((err) => {
console.warn('Failed to initialize system proxy cache:', err);
});
});
});

Menu.setApplicationMenu(menu);
const { maximized, x, y, width, height } = loadWindowState();
Expand Down
1 change: 1 addition & 0 deletions packages/bruno-electron/src/store/shell-env-state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ const { initializeShellEnv: _initializeShellEnv } = require('@usebruno/requests'

const TIMEOUT_MS = 60_000;

/** @type {null | Promise<any>} */
let _promise = null;

const _initWithTimeout = () => {
Expand Down
Loading