Skip to content

fix: don't re-encode already encoded characters#7792

Closed
prateek-bruno wants to merge 3 commits intousebruno:mainfrom
prateek-bruno:stop-reencoding-of-encoded-params
Closed

fix: don't re-encode already encoded characters#7792
prateek-bruno wants to merge 3 commits intousebruno:mainfrom
prateek-bruno:stop-reencoding-of-encoded-params

Conversation

@prateek-bruno
Copy link
Copy Markdown

Description

We were re-encoding already encoded characters in the url, causing them to fail. For example aws pre-signed url's are already encoded.

For example:

https://example.com/api?filter=status%257Cactive&sort=name%257Casc

Now we safely ignore such pattern while encoding again, so that they don't cause an issue.

Fixes #6048

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 17, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4d03ac50-2d89-493c-b84b-6ca1a31dc555

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@prateek-bruno
Copy link
Copy Markdown
Author

Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Content Type in Headers for File Upload to AWS through Pre Signed URL Wrong

1 participant