fix: correct typos in comments, error messages, and identifiers#5704
Merged
johnnyjoygh merged 1 commit intousememos:mainfrom Mar 8, 2026
Merged
Conversation
- store/db/mysql: "eroor" → "error" in DSN parse error message - plugin/storage/s3: "presign put object" → "presign get object" in PresignGetObject - plugin/idp/oauth2: "failed to new http request" → "failed to create http request" - plugin/cron/parser: "are parse in" → "are parsed in" in comment - proto/attachment_service: "a attachment" → "an attachment" (3 occurrences) - server/attachment_service: "save the blob" → "saves the blob" in godoc - web/i18n: rename isValidateLocale → isValidLocale Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
johnnyjoygh
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PresignGetObjecterror message (copy-paste bug)isValidateLocale→isValidLocale(grammatically incorrect predicate name)Test plan
buf generateisValidLocalerename is consistent across all 3 call sites ini18n.ts🤖 Generated with Claude Code