ls: doesn't list acl "+" status for symlinks

[seb128]

The acl package fails to rebuild on Ubuntu with coreutils-uutils
https://launchpadlibrarian.net/798206888/buildlog_ubuntu-questing-amd64.acl_2.3.2-2_BUILDING.txt.gz

$ ls --version
ls 0.0.30

$ mkdir d
$ setfacl -m u:bin:rwx d
$ ln -s d l
$ ls -lLd l
drwxrwxr-x 2 user user 2 Jun 18 09:20 l

using the coreutils version of ls it gives drwxrwxr-x+ (including the + of the acl, same as directly listing the directory)

[sylvestre]

bizarre, it should work
i already implemented this feature

[seb128]

I didn't try git, so it could be that the 0.30 version in Ubuntu doesn't include the fix yet?

[cakebaker]

I can reproduce it on main:

$ cargo run -q ls -lLd l
drwxrwxr-x 2 dho dho 4096 Jun 18 13:06 l
$ ls -lLd l
drwxrwxr-x+ 2 dho dho 4096 Jun 18 13:06 l

[sudhackar]

xattr::list is empty in has_acl for this path

$ strace -e llistxattr,listxattr,getxattr ./target/debug/coreutils ls -lLd l
llistxattr("l", 0x1, 0)                 = 0
llistxattr("l", 0x1, 0)                 = 0
drwxrwxr-x 2 sudhackar sudhackar 4096 Jun 18 16:47 l
+++ exited with 0 +++
$ strace -e llistxattr,listxattr,getxattr /bin/ls -lLd l
getxattr("l", "security.selinux", 0x64fcb963e290, 255) = -1 ENODATA (No data available)
listxattr("l", "system.posix_acl_access\0", 152) = 24
drwxrwxr-x+ 2 sudhackar sudhackar 4096 Jun 18 16:47 l
+++ exited with 0 +++

[sudhackar]

This seems to work correctly for the given file

diff --git a/src/uucore/src/lib/features/fsxattr.rs b/src/uucore/src/lib/features/fsxattr.rs
index 1913b0669..1f1356ee5 100644
--- a/src/uucore/src/lib/features/fsxattr.rs
+++ b/src/uucore/src/lib/features/fsxattr.rs
@@ -79,7 +79,7 @@ pub fn apply_xattrs<P: AsRef<Path>>(
 /// `true` if the file has extended attributes (indicating an ACL), `false` otherwise.
 pub fn has_acl<P: AsRef<Path>>(file: P) -> bool {
     // don't use exacl here, it is doing more getxattr call then needed
-    xattr::list(file).is_ok_and(|acl| {
+    xattr::list_deref(file).is_ok_and(|acl| {
         // if we have extra attributes, we have an acl
         acl.count() > 0
     })

We need to check the file is a symlink - which then uses llistxattr or listxattr - I can propose a fix and a test

$ strace -e llistxattr,listxattr,getxattr ./target/debug/coreutils ls -lLd l
listxattr("l", 0x1, 0)                  = 24
listxattr("l", "system.posix_acl_access\0", 24) = 24
drwxrwxr-x+ 2 sudhackar sudhackar 4096 Jun 18 16:47 l
+++ exited with 0 +++

[cakebaker]

I can propose a fix and a test

Yes, please do :)