Skip to content

expand, unexpand: Properly handle I/O errors#10510

Merged
sylvestre merged 2 commits intouutils:mainfrom
dezgeg:io_errors
Jan 27, 2026
Merged

expand, unexpand: Properly handle I/O errors#10510
sylvestre merged 2 commits intouutils:mainfrom
dezgeg:io_errors

Conversation

@dezgeg
Copy link
Contributor

@dezgeg dezgeg commented Jan 27, 2026

No description provided.

@dezgeg
Copy link
Contributor Author

dezgeg commented Jan 27, 2026

Part of #9857

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 27, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 56.2%

Comparing dezgeg:io_errors (e3fbbd8) with main (9cc9ca8)

Summary

⚡ 2 improved benchmarks
✅ 140 untouched benchmarks
⏩ 180 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation expand_many_lines[100000] 150.6 ms 96.4 ms +56.2%
Simulation expand_custom_tabstops[50000] 37.9 ms 25.1 ms +50.68%

Footnotes

  1. 180 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail/truncate. tests/tail/truncate is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

@dezgeg
Copy link
Contributor Author

dezgeg commented Jan 27, 2026

The remaining error seems unrelated intermittent one:

error: test failed, to rerun pass `-p coreutils --test tests`
failures:

---- test_sleep::test_sleep_stops_after_sigbus stdout ----
bin: "/Users/runner/work/coreutils/coreutils/target/x86_64-apple-darwin/debug/coreutils"
run: /Users/runner/work/coreutils/coreutils/target/x86_64-apple-darwin/debug/coreutils sleep 100

thread 'test_sleep::test_sleep_stops_after_sigbus' panicked at tests/uutests/src/lib/util.rs:2453:14:
called `Result::unwrap()` on an `Err` value: Custom { kind: Other, error: "kill: Timeout of '10s' reached" }
stack backtrace:
   0: rust_begin_unwind
             at /rustc/4d91de4e48198da2e33413efdcd9cd2cc0c46688/library/std/src/panicking.rs:692:5
   1: core::panicking::panic_fmt
             at /rustc/4d91de4e48198da2e33413efdcd9cd2cc0c46688/library/core/src/panicking.rs:75:14
   2: core::result::unwrap_failed
             at /rustc/4d91de4e48198da2e33413efdcd9cd2cc0c46688/library/core/src/result.rs:1704:5
   3: core::result::Result<T,E>::unwrap
             at /rustc/4d91de4e48198da2e33413efdcd9cd2cc0c46688/library/core/src/result.rs:1109:23
   4: uutests::util::UChild::kill_with_custom_signal
             at ./tests/uutests/src/lib/util.rs:2444:9
   5: tests::test_sleep::test_sleep_stops_after_sigbus
             at ./tests/by-util/test_sleep.rs:167:5
   6: tests::test_sleep::test_sleep_stops_after_sigbus::{{closure}}
             at ./tests/by-util/test_sleep.rs:161:35
   7: core::ops::function::FnOnce::call_once
             at /rustc/4d91de4e48198da2e33413efdcd9cd2cc0c46688/library/core/src/ops/function.rs:250:5
   8: core::ops::function::FnOnce::call_once
             at /rustc/4d91de4e48198da2e33413efdcd9cd2cc0c46688/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


failures:
    test_sleep::test_sleep_stops_after_sigbus

test result: FAILED. 4341 passed; 1 failed; 77 ignored; 0 measured; 0 filtered out; finished in 391.34s

I can't seem to locate the rerun tests button

@sylvestre sylvestre merged commit d1f1275 into uutils:main Jan 27, 2026
129 of 130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants