Skip to content

ls: Use rustc-hash at colors#10700

Merged
sylvestre merged 1 commit intouutils:mainfrom
oech3:lscolh
Mar 7, 2026
Merged

ls: Use rustc-hash at colors#10700
sylvestre merged 1 commit intouutils:mainfrom
oech3:lscolh

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Feb 4, 2026

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor

some jobs are failing

@oech3 oech3 force-pushed the lscolh branch 2 times, most recently from a5e44a1 to 9c1d041 Compare February 4, 2026 07:18
@oech3

This comment was marked as resolved.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 4, 2026

Merging this PR will not alter performance

✅ 294 untouched benchmarks
⏩ 42 skipped benchmarks1


Comparing oech3:lscolh (40d9da1) with main (9ac174b)

Open in CodSpeed

Footnotes

  1. 42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 marked this pull request as ready for review February 4, 2026 11:12
@oech3
Copy link
Contributor Author

oech3 commented Feb 4, 2026

Really 0% perf change. Just for binary size.

@sylvestre
Copy link
Contributor

Really 0% perf change. Just for binary size.

do you have the numbers ?

@oech3
Copy link
Contributor Author

oech3 commented Feb 4, 2026

stripped, current --release: 2172960 -> 2171200

@github-actions
Copy link

github-actions bot commented Feb 7, 2026

GNU testsuite comparison:

Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/pr/bounded-memory is no longer failing!

@oech3
Copy link
Contributor Author

oech3 commented Feb 25, 2026

needed for consistency for ls code.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/csplit/csplit-heap is now passing!

@sylvestre
Copy link
Contributor

needed for consistency for ls code.

could you please elaborate ?
thanks

@oech3
Copy link
Contributor Author

oech3 commented Feb 25, 2026

FxHash* is already used at ls.rs for perf. So we can use this at ls/src/colors.rs for consistency.

@sylvestre sylvestre merged commit b47076e into uutils:main Mar 7, 2026
156 checks passed
@oech3 oech3 deleted the lscolh branch March 7, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants