refactor: removing unnecessary references in fn signatures

[nyurik]

Address all suggestions of clippy::trivially_copy_pass_by_ref

Seems cleaner, and I wonder if perf would be affected

[codspeed-hq]

Merging this PR will not alter performance

✅ 284 untouched benchmarks
⏩ 38 skipped benchmarks¹

---

_{Comparing nyurik:refs (0e4c25e) with main (368230e)}

Footnotes

1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[sylvestre]

Could you please update the clippy configuration to make sure we don't regress in the future

[nyurik]

Could you please update the clippy configuration to make sure we don't regress in the future

already done -- this PR removes trivially_copy_pass_by_ref in Cargo.toml

[sylvestre]

i missed it, sorry

[xtqqczze]

https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

@nyurik In future, please add link to the lint in PR description

[xtqqczze]

https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

• It's quite possible this could regress performance on 32-bit targets, how about setting trivial-copy-size-limit = 4?
• The lint has issues with false positives introducing undefined behavior with unsafe code

[nyurik]

@xtqqczze should we optimize for 32 or for 64 bit platforms? I would optimize for 64 as a much more common one, and only look at specific exceptions if we identify any bottlenecks - this keeps code simpler (Copy values are easier to work with).

I haven't seen any unsafe usages - do you have any specific one in mind?

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)