mktemp: handle invalid UTF-8 in suffix gracefully#10818
Merged
ChrisDryden merged 1 commit intouutils:mainfrom Feb 8, 2026
Merged
mktemp: handle invalid UTF-8 in suffix gracefully#10818ChrisDryden merged 1 commit intouutils:mainfrom
ChrisDryden merged 1 commit intouutils:mainfrom
Conversation
Collaborator
|
So the test succeeds because it only checks to make sure that the directory is created, but the .to_string_lossy() changes the path. My opinion is we should still merge this anyways since the full fix would be to make the Params prefix and suffix stored as OsString and could be much bigger in scope |
|
GNU testsuite comparison: |
oech3
pushed a commit
to oech3/coreutils
that referenced
this pull request
Feb 9, 2026
cerdelen
pushed a commit
to cerdelen/coreutils
that referenced
this pull request
Feb 12, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should fix tests/mktemp/bad-unicode.sh