Unexpand use buffered reads + tests

[cerdelen]

New PR to fix issues after revert of #10798

Fix: #10698

[sylvestre]

do we need that many tests ? thanks

[cerdelen]

Every test is a different edge case around the chunking process. I thought rather have a few more than a few too little.

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/tail/tail-n0f is now passing!

[sylvestre]

yeah my point was that there is some duplications in the tests and they might be merged with a loop with different args / expectations

[codspeed-hq]

Merging this PR will improve performance by 58.43%

⚡ 2 improved benchmarks
✅ 282 untouched benchmarks
⏩ 38 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
⚡	Simulation	unexpand_many_lines[100000]	300.6 ms	189.7 ms	+58.4%
⚡	Simulation	unexpand_large_file[10]	630.1 ms	397.7 ms	+58.43%

---

_{Comparing cerdelen:unexpand_buffer (cdff1df) with main (7b0e7e4)}

Footnotes

1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[sylvestre]

for a different PR but it should be refactored
way too many arguments now

[sylvestre]

still waiting for some of the tests content to be deduplicated

[cerdelen]

Would be 1 function like this be acceptable?

#[test]
fn test_buffered_read_edgecase_behaviour() {
    let test_cases = [
        {
            // input has newlines in first chunk and has leading spaces after newline in chunk
            let mut input = vec![b'0'; 180];
            input.push(b'\n');
            input.extend([b' '; 8]);
            input.extend([b'0'; 3897]);
            input.push(b'\n');

            let mut expected = vec![b'0'; 180];
            expected.push(b'\n');
            expected.push(b'\t');
            expected.extend([b'0'; 3897]);
            expected.push(b'\n');
            (input, expected)
        },
        ... // other edgecases
    ]

    new_ucmd!()
        .pipe_in(input)
        .succeeds()
        .stdout_only(String::from_utf8(expected).unwrap());
}

[sylvestre]

sure

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/tail/tail-n0f is now passing!

[oech3]

Would you add keywords cspell does not like?

[cerdelen]

Yes i did, i am confused why cspell marks them as error. I double checked and behaviour is written correctly. Weird!

[oech3]

Maybe, cspell accepts en_US only? behavior

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/tail/tail-n0f is now passing!

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/pr/bounded-memory is no longer failing!