Merged
Conversation
Collaborator
|
Super nice! We can use this in almost every util |
Collaborator
|
I've previously implemented something very similar as a derive macro in the argument parser I was working on (which is currently paused until I find the time to work on it again). Spinning that out of that parser and into #[derive(Default, Debug, PartialEq, Eq, Value)]
enum Format {
#[value("long")]
Long,
#[value("single-column")]
SingleColumn,
#[default]
#[value("columns", "vertical")]
Columns,
#[value("across", "horizontal")]
Across,
#[value("commas")]
Commas,
}The code for the macro is here: https://github.com/tertsdiepraam/uutils-args/blob/2f1a9b0ed0a328d600992e08a0950a07761a8a3b/derive/src/lib.rs#L115 |
a86e6f1 to
643afbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
ShortcutValueParser, a custom value parser for clap that not only recognizes the exact values from a list of allowed values but also shortcuts of them (for example,h,ho,hou, are recognized ashour).Closes #4744