Skip to content

df: disable failing tests on Windows#5017

Merged
sylvestre merged 1 commit intouutils:mainfrom
cakebaker:df_disable_some_tests_on_windows
Jul 3, 2023
Merged

df: disable failing tests on Windows#5017
sylvestre merged 1 commit intouutils:mainfrom
cakebaker:df_disable_some_tests_on_windows

Conversation

@cakebaker
Copy link
Contributor

@cakebaker cakebaker commented Jun 28, 2023

This PR disables the four tests mentioned in #5015 on Windows.

@sylvestre
Copy link
Contributor

I would like to know a bit more why we regressed :/

@cakebaker
Copy link
Contributor Author

Yes, that would be nice, though I have no more ideas how to figure it out. In my experiments (running cargo update; testing v0.0.19; using windows 2019 in the workflow file) the four df tests still failed on Windows.

@sylvestre
Copy link
Contributor

@cakebaker #5026 some improvements here
once it is merged, we can adjust this PR

@sylvestre sylvestre merged commit 6e3ab23 into uutils:main Jul 3, 2023
@cakebaker cakebaker deleted the df_disable_some_tests_on_windows branch July 3, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants