util/build-gnu.sh: Improve error message when missing GNU Coreutils repository#5019
Merged
cakebaker merged 1 commit intouutils:mainfrom Jun 29, 2023
Merged
Conversation
For a new contributor, the message given by `utils/build-gnu.sh` is fairly confusing - it starts with several lines of noise (showing variables that are set in the script) followed by an error about missing "GNU" and a `git` command string. This commit changes the script to explicitly instruct the user to run the `git clone` command. Since the GNU coreutils repository is probably missing for new developers, this error is shown if the repository is missing without including VARIABLE=value lines that are not actionable yet.
sylvestre
force-pushed
the
explain-gnu-build-clone
branch
from
b97f10f to
9bf1fb5
Compare
Contributor
|
Thanks for your PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a new contributor, the message given by
utils/build-gnu.shisfairly confusing - it starts with several lines of noise (showing
variables that are set in the script) followed by an error about missing
"GNU" and a
gitcommand string.This PR changes the script to explicitly instruct the user to run
the
git clonecommand. Since the GNU coreutils repository is probablymissing for new developers, this error is shown if the repository is
missing without including any VARIABLE=value lines that are not actionable
yet.