stty: Support setting baud rate#5053
Merged
tertsdiepraam merged 1 commit intouutils:mainfrom Jul 8, 2023
Merged
Conversation
Collaborator
|
Looks good! Do you think maybe we should give an error if an unsupported baud rate is given on the platforms where it's based on an enum? |
Contributor
Author
|
It does eventually end up into the invalid argument case on Linux and give same error message as GNU does |
tertsdiepraam
approved these changes
Jul 8, 2023
Collaborator
tertsdiepraam
left a comment
There was a problem hiding this comment.
Seems to work fine!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3859.