Skip to content

stty: Support setting baud rate#5053

Merged
tertsdiepraam merged 1 commit intouutils:mainfrom
dezgeg:stty-baudrate
Jul 8, 2023
Merged

stty: Support setting baud rate#5053
tertsdiepraam merged 1 commit intouutils:mainfrom
dezgeg:stty-baudrate

Conversation

@dezgeg
Copy link
Contributor

@dezgeg dezgeg commented Jul 7, 2023

Part of #3859.

@tertsdiepraam
Copy link
Collaborator

Looks good! Do you think maybe we should give an error if an unsupported baud rate is given on the platforms where it's based on an enum?

@dezgeg
Copy link
Contributor Author

dezgeg commented Jul 8, 2023

It does eventually end up into the invalid argument case on Linux and give same error message as GNU does

stty: invalid argument '12345'

Copy link
Collaborator

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine!

@tertsdiepraam tertsdiepraam merged commit 24c2743 into uutils:main Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants