stty: Finish '--save' support#5054
Merged
tertsdiepraam merged 1 commit intouutils:mainfrom Jul 8, 2023
Merged
Conversation
Argument parsing for this exists, but the option doesn't change output in any way. Finish the support. Closes uutils#3862
|
GNU testsuite comparison: |
Collaborator
|
Nice! Yeah I couldn't find any docs either, that's why I left it out of my original implementation. This looks good though :) |
tertsdiepraam
approved these changes
Jul 8, 2023
Collaborator
tertsdiepraam
left a comment
There was a problem hiding this comment.
We should set up some way to test stty too, but that's out of scope for this PR. On my local machine, the output seems to match up with GNU. Great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Argument parsing for this exists, but the option doesn't change output in any way. Finish the support.
Closes #3862.
I haven't found any documentation on the format of this or looked at any code, but it would appear to be simple hex printing of some (not all) struct termios fields: