stty: Implement printing assignment of control chars#5060
Merged
sylvestre merged 1 commit intouutils:mainfrom Jul 17, 2023
Merged
stty: Implement printing assignment of control chars#5060sylvestre merged 1 commit intouutils:mainfrom
sylvestre merged 1 commit intouutils:mainfrom
Conversation
dezgeg
force-pushed
the
stty-control-chars
branch
from
020cfb8 to
fbccf4d
Compare
|
GNU testsuite comparison: |
dezgeg
force-pushed
the
stty-control-chars
branch
2 times, most recently
from
ab2ec87 to
b1fe459
Compare
Collaborator
|
Very cool to see |
dezgeg
force-pushed
the
stty-control-chars
branch
5 times, most recently
from
15c4afe to
b8aa468
Compare
sylvestre
reviewed
Jul 12, 2023
sylvestre
reviewed
Jul 12, 2023
dezgeg
force-pushed
the
stty-control-chars
branch
from
a1dda74 to
8eceb70
Compare
sylvestre
reviewed
Jul 12, 2023
dezgeg
force-pushed
the
stty-control-chars
branch
4 times, most recently
from
2787fe4 to
d2b7643
Compare
|
GNU testsuite comparison: |
Part of uutils#3861. Code comments from sylvestre. Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
dezgeg
force-pushed
the
stty-control-chars
branch
from
d2b7643 to
96dbd6d
Compare
Contributor
|
is it too hard to write tests for these? |
|
GNU testsuite comparison: |
Contributor
Author
Main problem is in the existing tests there isn't anything suitable to start modifying; existing cases either test fails that happen in argument parsing stage or are not run due to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3861