ci: add default_trait_access lint and fix its warnings#5081
Merged
sylvestre merged 2 commits intouutils:mainfrom Jul 14, 2023
Merged
ci: add default_trait_access lint and fix its warnings#5081sylvestre merged 2 commits intouutils:mainfrom
sylvestre merged 2 commits intouutils:mainfrom
Conversation
Contributor
|
I guess you saw the similar warnings: |
Contributor
Author
|
This is fixed in #5079 |
20ca27e to
236789f
Compare
e969709 to
3dedce4
Compare
fe42a6e to
c525c23
Compare
c525c23 to
a0f527c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the pedantic default_trait_access lint to the CICD and fixes its warnings.