fuzzing: remove some duplicated code + clippy fixes#5337
Merged
cakebaker merged 2 commits intouutils:mainfrom Sep 30, 2023
sylvestre:fuzz3
Merged
fuzzing: remove some duplicated code + clippy fixes#5337cakebaker merged 2 commits intouutils:mainfrom sylvestre:fuzz3
cakebaker merged 2 commits intouutils:mainfrom
sylvestre:fuzz3
Conversation
cakebaker
reviewed
Sep 29, 2023
| pub fn run_gnu_cmd( | ||
| cmd_path: &str, | ||
| args: &[OsString], | ||
| check_gnu: bool, |
Contributor
There was a problem hiding this comment.
An alternative to the check_gnu param could be to split run_gnu_cmd into two functions. This would avoid the "magic" boolean values when calling run_gnu_cmd.
cakebaker
approved these changes
Sep 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.