head: remove a clippy::cognitive_complexity by moving some content in a function#5366
Merged
cakebaker merged 2 commits intouutils:mainfrom Oct 7, 2023
sylvestre:wc-s
Merged
head: remove a clippy::cognitive_complexity by moving some content in a function#5366cakebaker merged 2 commits intouutils:mainfrom sylvestre:wc-s
cakebaker merged 2 commits intouutils:mainfrom
sylvestre:wc-s
Conversation
cakebaker
changed the title
cakebaker
reviewed
Oct 7, 2023
src/uu/head/src/parse.rs
Outdated
Comment on lines
+41
to
+44
| /// Processes the numeric block of the input string to generate the appropriate options. | ||
| /// | ||
| /// This function is responsible for parsing the numeric section of the input string | ||
| /// and generating the corresponding options based on the parsed value and subsequent characters. |
Contributor
There was a problem hiding this comment.
Both sentences say more or less the same, so I think one of them can be removed.
cakebaker
reviewed
Oct 7, 2023
Contributor
cakebaker
left a comment
cakebaker
left a comment
There was a problem hiding this comment.
The code looks good, only the commit message is incorrect as the change is about head and not wc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.