Skip to content

rm: In some cases, remove_dir is doing a better job than remove_dir_all#5403

Merged
cakebaker merged 2 commits intouutils:mainfrom
sylvestre:rm
Oct 16, 2023
Merged

rm: In some cases, remove_dir is doing a better job than remove_dir_all#5403
cakebaker merged 2 commits intouutils:mainfrom
sylvestre:rm

Conversation

@sylvestre
Copy link
Contributor

use it when remove_dir_all failed

GNU compatibility (rm/empty-inacc.sh)

use it when remove_dir_all failed

GNU compatibility (rm/empty-inacc.sh)
@sylvestre
Copy link
Contributor Author

it doesn't fully fix the test
Next is

fail=0
mkdir -m a-r -p a/unreadable
rm -rf a
echo $fail
test -d a && fail=1
echo $fail

which should pass

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/rm/unreadable is no longer failing!

@sylvestre
Copy link
Contributor Author

GNU testsuite comparison:

Congrats! The gnu test tests/rm/unreadable is no longer failing!

Well this is an unexpected good result :)

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/rm/unreadable is no longer failing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants