join: remove crash! macro

[cswn]

This is related to issue #5487. Removes the crash! macro from join.

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/tail/symlink. tests/tail/symlink is passing on 'main'. Maybe you have to rebase?

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/tail/inotify-dir-recreate. tests/tail/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

[tertsdiepraam]

Nice! I think you're on the right track and the solution is correct, but I do have a suggestion to make it a bit more like the other utils (and not having to use the UnorderedInput variant).

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/tail/inotify-dir-recreate. tests/tail/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/truncate. tests/tail/truncate is passing on 'main'. Maybe you have to rebase?

[tertsdiepraam]

Excellent work! This is exactly what I had in mind. Because we now use UResult I think we can also remove this bit:

https://github.com/uutils/coreutils/blob/a064c886566f810c3e58b1b1153762e772e35567/src/uu/join/src/join.rs#L704-L707C6

and just make that a call to exec and return the result. And then we can merge this.

[cswn]

Awesome, thanks 😄 Let me know if this is what you had in mind.

[tertsdiepraam]

Yes, that's it! I'll wait for the CI but seems ready to be merged. Thanks!

[cakebaker]

Thanks!