expr: different stderr with expr "56" "substr"#5559
Merged
sylvestre merged 2 commits intouutils:mainfrom Nov 22, 2023
Merged
Conversation
sylvestre
force-pushed
the
expr-substr-error
branch
from
0300874 to
8b650a7
Compare
Contributor
|
thanks! |
Collaborator
|
Looks like a test from this PR is failing in some PR pipelines, which is strange because it's passing here. |
Contributor
Author
|
Could be because of the force-pushed rebase above? In the background, I'm working on a dockerized test environment, so maybe we could have the tests behave a little more consistently. |
cakebaker
added a commit
to cakebaker/coreutils
that referenced
this pull request
Nov 23, 2023
cakebaker
added a commit
to cakebaker/coreutils
that referenced
this pull request
Nov 23, 2023
sylvestre
added a commit
that referenced
this pull request
Nov 23, 2023
expr: adapt error messages, revert most of #5559
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As addressed in #5558 , this PR aligns the error messages from this implementation of
exprwith the GNU one.If there are no arguments, it returns
expr: missing operand.If one of the arguments introduced arity, but there are not enough arguments, it returns
expr: syntax error: unexpected argument 'substr'with the name of that argument, likesubstr.Added tests.