Merged
Conversation
cakebaker
reviewed
Dec 21, 2023
Contributor
cakebaker
left a comment
There was a problem hiding this comment.
The change itself looks good. With the test, I think it is a bit of an overkill to introduce an additional fixture and you could simply use the fixture used in test_with_trailing_tab_i.
Contributor
Author
|
@cakebaker Do you know why the GNU test failed? Or should I run |
Contributor
|
Just ignore it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
expandfailed when executing multiple args. See #5671GNU:
Current uutils/coreutils:
Expected behavior for uutils/coreutils: